[chore] Improve the Makefile to make it more robust to other environments. #1063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
podman-is-docker
where/etc/containers/registries.conf
does not contain a fallback registry for security reasons and thus requires that the container registry be specified explicitly.2 . Failure with "fatal: No names found ..." when using
make compatibility-check
in developer branches.Details
This change improves the
Makefile
by providing an explicit registry for theotel/weaver
andotel/semconvgen
containers. By default, it prefixes these withdocker.io/
, but uses a variable to make it easy to override.In addition, the logic for determining the latest version of the semantic conventions is updated from using
git describe
togit ls-remote
so that light-weight branches that haven't pulled down the list of tags can also invoke this.Merge requirement checklist
[chore]
^^^^ Done
^^^^ N/A; does not update existing conventions